yandrey321 commented on code in PR #11617:
URL: https://github.com/apache/ozone/pull/11617#discussion_r4496447040
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/WritableRatisContainerProvider.java:
##########
@@ -143,14 +153,35 @@ public ContainerInfo getContainer(final long size,
@Nullable
private ContainerInfo getContainer(ReplicationConfig repConfig, String owner,
- ExcludeList excludeList, PipelineRequestInformation req) {
+ ExcludeList excludeList, PipelineRequestInformation req, DatanodeDetails
client) {
// Acquire pipeline manager lock, to avoid any updates to pipeline
// while allocate container happens. This is to avoid scenario like
// mentioned in HDDS-5655.
pipelineManager.acquireReadLock();
try {
List<Pipeline> availablePipelines = findPipelinesByState(repConfig,
Review Comment:
it would be nice to have API for getting leader leaderPipelines,
localPipelines and other pipelines maps cached, so we would not need to iterate
through pipelines on every getContainer() call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
