adoroszlai commented on code in PR #11977:
URL: https://github.com/apache/ozone/pull/11977#discussion_r4506832694


##########
.github/workflows/ci.yml:
##########
@@ -220,7 +216,7 @@ jobs:
         check: ${{ fromJson(needs.build-info.outputs.basic-checks) }}
         exclude:
           - check: errorprone
-      fail-fast: false
+      fail-fast: true

Review Comment:
   Basic checks are mostly deterministic.  Intermittency may be mainly due to 
infrastructure.  Failures usually require new commit, and thus a new full run.  
They are also quick, so re-run does not cost much.
   
   On the other hand, tests are more prone to flakiness, and some splits are 
very long.  Cancelling a few 40 minute runs at 30 minutes because some flaky 
test in one split failed is a waste of resources.
   
   We turned off `fail-fast` (HDDS-6464) when GitHub introduced "Re-run failed 
checks" -- before that, all checks had to be re-run anyway, so waiting for some 
to finish successfully did not make sense.  I don't recall why we did not keep 
it for basic checks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to