rich7420 opened a new pull request, #11985:
URL: https://github.com/apache/ozone/pull/11985

   ## What changes were proposed in this pull request?
   
   `OzoneManager#checkFeatureEnabled` rejects a feature listed in the private 
config `ozone.om.features.disabled`, so a test can make OM refuse a feature it 
supports. Only `ATOMIC_REWRITE_KEY` is disabled anywhere, by the 
`compatibility` acceptance test. OM also checks `S3_IF_NONE_MATCH_ETAG` and 
`ATOMIC_CREATE_IF_NOT_EXISTS`, which no test disables, and new changes keep 
copying these checks as if they were a version gate.
   
   Remove those checks from `OMKeyCreateRequest`, `OMKeyCommitRequest` and 
`S3MultipartUploadCompleteRequest`, keep the `ATOMIC_REWRITE_KEY` checks, and 
document `checkFeatureEnabled` as a test hook. The two 
`ATOMIC_CREATE_IF_NOT_EXISTS` skips in `OzoneRpcClientTests` go too, since OM 
no longer checks that feature.
   
   ## What is the link to the Apache JIRA
   
   [HDDS-17754](https://issues.apache.org/jira/browse/HDDS-17754)
   
   ## How was this patch tested?
   
   Unit tests of the three requests and the `TestOzoneRpcClient` 
create-if-not-exists and rewrite tests passed locally.
   
   [Fork CI](https://github.com/rich7420/ozone/actions/runs/42556368054): 
pending.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to