devmadhuu commented on code in PR #11626:
URL: https://github.com/apache/ozone/pull/11626#discussion_r4511674018


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMStoragePolicyUpgrade.java:
##########
@@ -129,79 +89,41 @@ private void preFinalizationChecks() throws Exception {
     // Controls: the gate must not reject requests that carry no storage 
policy field
     createBucket(null, null);
     // The client API must not add a policy field on its own, or the gate 
rejects this request.
-    String clientCreated = "buck-" + UUID.randomUUID();
-    client.getObjectStore().getVolume(VOLUME_NAME).createBucket(clientCreated);
-    assertThat(omClient.getBucketInfo(VOLUME_NAME, 
clientCreated).getStoragePolicy()).isNull();
-    omClient.setBucketProperty(OmBucketArgs.newBuilder()
+    String clientCreated = createBucket(null, null);

Review Comment:
   Could we retain the public client API calls for this check? They previously 
verified that ordinary bucket creation succeeds before finalization without the 
client inserting a policy, and uses OM’s configured COLD default afterward. The 
direct-OM helper bypasses that behavior. Better to use client API like it was 
using in earlier to create bucket.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to