rich7420 commented on code in PR #11740:
URL: https://github.com/apache/ozone/pull/11740#discussion_r4514170929


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java:
##########
@@ -300,6 +300,13 @@ public static OMClientRequest 
createClientRequest(OMRequest omRequest,
       break;
     case DeleteKey:
       keyArgs = omRequest.getDeleteKeyRequest().getKeyArgs();
+      if (omRequest.getAssumeS3Context()) {
+        // Resolve before choosing the bucket layout and write the resolved 
volume to Ratis.
+        keyArgs = keyArgs.toBuilder().setVolumeName(
+            
ozoneManager.getS3VolumeContext().getOmVolumeArgs().getVolume()).build();

Review Comment:
   I think I'd keep it. FSO deletes check ACLs via `checkACLsWithFSO`, which 
only checks the key, so with Ranger this is the only volume READ check. 
`getKeyInfo` can skip it because `checkAllAcls` checks the volume.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to