sadanand48 commented on code in PR #11962:
URL: https://github.com/apache/ozone/pull/11962#discussion_r4512242785


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/endpoint/HeartbeatEndpointTask.java:
##########
@@ -109,6 +118,18 @@ public HeartbeatEndpointTask(EndpointStateMachine 
rpcEndpoint,
         HDDS_PIPELINE_ACTION_MAX_LIMIT_DEFAULT);
     this.maxReportsPerHB = Math.max(1, 
conf.getInt(HDDS_HEARTBEAT_REPORT_MAX_LIMIT,
         HDDS_HEARTBEAT_REPORT_MAX_LIMIT_DEFAULT));
+    this.maxCommandStatusReportBytes = (long) conf.getStorageSize(

Review Comment:
   This was intentional as I didn't want the command status to be fully part of 
the 128MB heartbeat, without  separate 64 MB configuration and 0.9% of 128MB 
command statuses could consume almost the entire 90% allowance every heartbeat 
during recovery. Maybe it could be 50% of the max however IMO 64MB should work.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to