errose28 commented on PR #12004:
URL: https://github.com/apache/ozone/pull/12004#issuecomment-6778274286

   OM side looks good. Now that we have the OM and SCM tests mapped out I think 
we should combine them. There is a lot of duplication between the two and it is 
difficult to find potential gaps that might be covered by one service and not 
the other. I had Claude combine the tests on [this 
branch](https://github.com/errose28/ozone/tree/pr-12004-combined-tests). This 
leaves us with three test files:
   
   - The OM and SCM tests were actually just using the 
`RatisBasedVersionManager` directly. Now that functionality is covered in 
`AbstractRatisBasedVersionManagerTest`.
   - `Test{OM,SCM}StartupVersionReconciliation` now handles component specific 
invocation of the start methods for DB finalization and failure with invalid 
versions.
     - The OM test no longer waits for a leader election so it finishes in ~3 
seconds.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to