adoroszlai commented on code in PR #11962:
URL: https://github.com/apache/ozone/pull/11962#discussion_r4561937440
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsConfigKeys.java:
##########
@@ -73,6 +73,13 @@ public final class HddsConfigKeys {
"hdds.heartbeat.report.max.limit";
public static final int HDDS_HEARTBEAT_REPORT_MAX_LIMIT_DEFAULT =
10000;
+ public static final String HDDS_HEARTBEAT_COMMAND_STATUS_REPORT_MAX_SIZE =
+ "hdds.heartbeat.command.status.report.max.size";
+ public static final String
HDDS_HEARTBEAT_COMMAND_STATUS_REPORT_MAX_SIZE_DEFAULT = "64MB";
+ public static final String HDDS_IPC_MAXIMUM_DATA_LENGTH =
+ "ipc.maximum.data.length";
Review Comment:
@sadanand48 `TestOzoneConfigurationFields` failed.
`ipc.maximum.data.length` should not be declared in `HddsConfigKeys` (since
`ozone-default.xml` does not have it, nor should it), but in a non-config class
(which is not checked by `TestOzoneConfigurationFields`). For now it can be
moved to e.g. `HeartbeatEndpointTask`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]