yandrey321 commented on code in PR #11971:
URL: https://github.com/apache/ozone/pull/11971#discussion_r4569952974
##########
hadoop-ozone/ozonefs-common/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystemHeadOp.java:
##########
@@ -48,6 +54,12 @@
*/
public class TestOzoneFileSystemHeadOp {
+ private static final BlockLocation[] BLOCKS = {
+ new BlockLocation(new String[] {"dn1:9859"}, new String[] {"dn1"}, 0,
100),
+ new BlockLocation(new String[] {"dn2:9859"}, new String[] {"dn2"}, 100,
100),
+ new BlockLocation(new String[] {"dn3:9859"}, new String[] {"dn3"}, 200,
50),
+ };
Review Comment:
Kept as is. `TestOzoneFileSystemHeadOp` and
`TestRootedOzoneFileSystemHeadOp` mirror each other for o3fs and ofs, and they
mock different adapter types (`BasicOzoneClientAdapterImpl` and
`BasicRootedOzoneClientAdapterImpl`). A shared utility for about 15 lines of
fixture would add a test-only abstraction that neither class needs, so I
followed the existing structure of the two classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]