amaliujia commented on code in PR #11988:
URL: https://github.com/apache/ozone/pull/11988#discussion_r4582414367
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueHandler.java:
##########
@@ -1331,6 +1339,72 @@ private static OzoneContainer
mockOzoneContainerWithSCDomainSocket() {
return ozoneContainer;
}
+ private static Stream<Arguments> blockResponseStorageTypes() {
+ return Stream.of(null, StorageType.DISK, StorageType.SSD,
StorageType.ARCHIVE)
+ .flatMap(recordedType -> Stream.of(null, StorageType.DISK,
StorageType.SSD, StorageType.ARCHIVE)
+ .map(storedType -> Arguments.of(recordedType, storedType)));
+ }
+
+ @ParameterizedTest
+ @MethodSource("blockResponseStorageTypes")
+ public void testBlockResponsesUseContainerStorageType(StorageType
recordedType, StorageType storedType)
Review Comment:
Overall LGTM.
Just want to confirm that we intend to use the `StorageType`, not
`VolumeStorageType` for the block response?
I am asking because I am not sure if we want to return the storage type that
the block bits physically sit in, and IIUC, `Storage Type` and
`VolumeStorageType` could differ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]