amaliujia commented on PR #11997: URL: https://github.com/apache/ozone/pull/11997#issuecomment-6912483331
@fmorg-git looks like it worths splitting this PR to two to address the following separately, WDYT? ``` 1. Client (BlockDataStreamOutput): mid-stream PutBlock commands registered their buffers with the commit watcher, but the stream-close PutBlock did not. After a successful close, the buffers it covered stayed in the per-key bufferList shared by all blocks of the key. If a later block then failed, computeBufferData() counted those stale buffers and writeOnRetry() wrote them again into the new block, so the committed key contained duplicated data and had the wrong length. 2. Datanode (ContainerStateMachine): streamPutBlock ignored the result of dispatchCommand. When the PutBlock on stream close was rejected (for example, the container was CLOSED), the channel was still marked linked and stream close succeeded, so the client believed the block was committed. This change: ยทยทยท -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
