fmorg-git commented on code in PR #12055:
URL: https://github.com/apache/ozone/pull/12055#discussion_r4594807672


##########
hadoop-ozone/dist/src/main/smoketest/ozone-lib/batch-shell.robot:
##########
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+*** Settings ***
+Documentation    Ozone Shell operations using Batch
+Resource         ../ozone-lib/batch.robot
+
+
+*** Keywords ***
+Put and Get Key Later
+    [arguments]    ${put_to}    ${get_from}=${put_to}    
${put_from}=/etc/passwd
+    Execute Later ozone sh    key put ${put_to} ${put_from}
+    ${get_to} =    Get Key Later    ${get_from}
+    Assert Later    Compare Files    ${put_from}    ${get_to}
+
+
+Get Key Later
+    [arguments]    ${get_from}
+    ${get_to} =    Get Next Filename    ${TEMP_DIR}/key-get

Review Comment:
   are the files in `${TEMP_DIR}` cleaned up? if not, can files created in 
`ozone-shell-single.robot` and `ozone-shell.robot` leak between tests and 
confuse the assertions?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to