fmorg-git commented on code in PR #11931:
URL: https://github.com/apache/ozone/pull/11931#discussion_r4606285302
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/s3/multipart/S3MultipartUploadCompleteResponse.java:
##########
@@ -70,18 +70,19 @@ public S3MultipartUploadCompleteResponse(
}
/**
- * For when the request is not successful.
- * For a successful request, the other constructor should be used.
+ * For failed requests or retries of completed uploads, which require no
database changes.
*/
public S3MultipartUploadCompleteResponse(@Nonnull OMResponse omResponse,
@Nonnull BucketLayout bucketLayout)
{
super(omResponse, bucketLayout);
- checkStatusNotOK();
Review Comment:
would it work to use `DummyOMClientResponse` for the retry case and leave
the `checkStatusNotOK()` here in this constructor for the error case? It may
not require the `omKeyInfo == null` check in `addToDBBatch` as well if
`DummyOMClientResponse` is used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]