devmadhuu commented on code in PR #11965:
URL: https://github.com/apache/ozone/pull/11965#discussion_r4616485590


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java:
##########
@@ -473,7 +486,10 @@ public BackgroundTaskQueue getTasks() {
           LOG.warn("Failed to persist updated DiskBalancerInfo to file.", e);
         }
       }
-      metrics.incrIdleLoopNoAvailableVolumePairCount();
+      // Rejection by the service does not mean the policy found no balancing 
work.
+      if (!rejectedCandidate) {
+        metrics.incrIdleLoopNoAvailableVolumePairCount();
+      }

Review Comment:
   Fixed the stop condition. Kindly have a look.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to