ChenSammi commented on code in PR #12038:
URL: https://github.com/apache/ozone/pull/12038#discussion_r4626458775


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java:
##########
@@ -217,13 +219,32 @@ private OMResponse internalProcessRequest(OMRequest 
request) throws ServiceExcep
         return 
response.toBuilder().setCreateKeyResponse(response.getCreateKeyResponse().toBuilder()
             .setDerivedKey(derivedKey)).build();
       }
+      if (response.getSuccess() && response.hasRecoverLeaseResponse()) {

Review Comment:
   Thanks @fmorg-git for the change, overall looks good to me. 
   
   Just one thought about this, instead of add the specific check and handling 
one by one, is it able to introduce a postExecute() for each request handler 
with default implementation? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to