devmadhuu commented on code in PR #12062:
URL: https://github.com/apache/ozone/pull/12062#discussion_r4628345534


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerReplica.java:
##########
@@ -150,6 +150,14 @@ public StorageType getVolumeStorageType() {
     return volumeStorageType;
   }
 
+  /**
+   * Returns the recorded replica type, or its reported volume type when the 
recorded type is absent.
+   * A null result means neither type is known. Callers must handle 
conflicting known types separately.
+   */
+  public StorageType getTargetStorageTypeForCopy() {

Review Comment:
   I think method name is fine because this storage type is in the context of 
caller , where we are trying to know the target replica copy from recorded 
source replica. So would like to keep it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to