adoroszlai commented on code in PR #12100: URL: https://github.com/apache/ozone/pull/12100#discussion_r4642418236
########## .github/workflows/post-commit.yml: ########## @@ -55,7 +56,14 @@ concurrency: permissions: contents: read jobs: + cache: + uses: $/.github/workflows/populate-cache.yml + if: github.event_name != 'pull_request' + CI: + needs: + - cache + if: always() # even if cache is skipped or fails Review Comment: Good point. For some reason I thought `always()` is required to overcome skipped `needs`. Now I checked docs, any condition should be enough to override implicit `if: success()` condition. https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#status-check-functions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
