sadanand48 commented on code in PR #11962:
URL: https://github.com/apache/ozone/pull/11962#discussion_r4657275527


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/endpoint/HeartbeatEndpointTask.java:
##########
@@ -153,21 +169,22 @@ public EndpointStateMachine.EndPointStates call() throws 
Exception {
       requestBuilder = SCMHeartbeatRequestProto.newBuilder()
           .setDatanodeDetails(datanodeDetailsProto)
           .setDatanodeVersion(versionInfo);
-      addReports(requestBuilder);
-      addContainerActions(requestBuilder);
-      addPipelineActions(requestBuilder);
-      addQueuedCommandCounts(requestBuilder);
+      SerializedSizeAccumulator heartbeatSize = new 
SerializedSizeAccumulator();
+      heartbeatSize.add(SCMHeartbeatRequestProto.DATANODEDETAILS_FIELD_NUMBER, 
datanodeDetailsProto);
+      heartbeatSize.add(SCMHeartbeatRequestProto.DATANODEVERSION_FIELD_NUMBER, 
versionInfo);
+      int reportCount = addNonCommandStatusReports(requestBuilder, 
heartbeatSize);
+      addContainerActions(requestBuilder, heartbeatSize);
+      addPipelineActions(requestBuilder, heartbeatSize);
+      addQueuedCommandCounts(requestBuilder, heartbeatSize);
+      addCommandStatusReports(
+          requestBuilder, maxReportsPerHB - reportCount, heartbeatSize.get());

Review Comment:
   With the default 500k limit, the resulting ACK is well below the safe 
heartbeat budget. Increasing that limit requires reviewing the IPC limit as 
documented in ScmConfig. We intentionally retain and log an unsendable ACK 
rather than dropping or reordering it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to