adoroszlai commented on PR #12065: URL: https://github.com/apache/ozone/pull/12065#issuecomment-7078709327
Thanks @len548 for the patch, @szetszwo for the review. > Existing problem: This is incorrect since the `respFuture` is already completed here. Calling respFuture.completeExceptionally(..) has no effect. > > * It should throw CompletionException. > * Then, all the calls are just catch IOException and then throw CompletionException. We should change validateResponse(..) to throw CompletionException. Thanks @szetszwo for reporting this. Let's do it in follow-up, created HDDS-17889. Since you provided the suggested fix, would you like to post a pull request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
