sadanand48 commented on a change in pull request #2533:
URL: https://github.com/apache/ozone/pull/2533#discussion_r690403431
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequest.java
##########
@@ -197,4 +198,118 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
return omClientResponse;
}
+ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
Review comment:
Can we avoid copying the same method here? We can call the new method
with null bucket layout in the above method.
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequest.java
##########
@@ -197,4 +198,118 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
return omClientResponse;
}
+ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
Review comment:
Why do we need bucketLayout for keyDelete? We deduce the bucketLayout in
OzoneManagerRatisUtils and create appropriate request right . Is this method
only created for unit test?
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/TestOMRequestUtils.java
##########
@@ -439,6 +441,21 @@ public static void addBucketToDB(String volumeName, String
bucketName,
new CacheValue<>(Optional.of(omBucketInfo), 1L));
}
+ public static void addBucketToDB(String volumeName, String bucketName,
Review comment:
same here. Can we avoid copying the method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
