bharatviswa504 commented on a change in pull request #2491: URL: https://github.com/apache/ozone/pull/2491#discussion_r696393594
########## File path: hadoop-ozone/interface-client/src/main/proto/OMMetadataProtocol.proto ########## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +/** + * These .proto interfaces are private and unstable. + * Please see http://wiki.apache.org/hadoop/Compatibility + * for what changes are allowed for a *unstable* .proto interface. + */ + +syntax = "proto2"; +option java_package = "org.apache.hadoop.ozone.protocol.proto"; +option java_outer_classname = "OzoneManagerMetadataProtocolProtos"; +option java_generic_services = true; +option java_generate_equals_and_hash = true; +package hadoop.ozone; + +/** +This file contains the metadata protocol for Ozone Manager(s). This involves +getting the meta information about an individual OM. +*/ + +message OMMetadataInfoRequest { +} + +message OMMetadataInfoResponse { + required bool success = 1; + optional string errorMsg = 2; + // OM nodes present in OM's memory + repeated OMNodeInfo nodesInMemory = 3; + // OM nodes reloaded from new config on disk + repeated OMNodeInfo nodesInNewConf = 4; + +} + +message OMNodeInfo { + required string nodeID = 1; + required string hostAddress = 2; Review comment: Just a question dont we need to worry about other configs like http/https addr? I see when ``` String rpcAddrKey = ConfUtils.addKeySuffixes(OZONE_OM_ADDRESS_KEY, omServiceId, omNodeId); String rpcAddrStr = OmUtils.getOmRpcAddress(conf, rpcAddrKey); if (rpcAddrStr == null || rpcAddrStr.isEmpty()) { return null; } if (newOMNodeDetails == null) { // If new node information is not present in the newly loaded // configuration also, throw an exception throw new OzoneIllegalArgumentException("There is no OM configuration " + "for node ID " + newOMNodeId + " in ozone-site.xml."); } ``` so if rpcAddr is null, we throw IllegalArgumentException. I believe that is causing crash here. With current way we check if rpc address is set for new om node id on existing OM's, but if other configs are not set like http/https addr we fail during download checkpoint right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
