sodonnel opened a new pull request #2591: URL: https://github.com/apache/ozone/pull/2591
## What changes were proposed in this pull request? TestContainerReplication#testSkipDecommissionAndMaintenanceNode() was added as part of HDDS-5296. The test runs 3 times and sleeps for 30 seconds on each run to wait to ensure replication never hits an out of service node. Aside from the 30 second sleep, each run of the test takes about 1 minute, so 3 minutes in total for this test. This class takes about 370 seconds on every pull request: ``` [INFO] Running org.apache.hadoop.ozone.container.TestContainerReplication [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 368.92 s - in org.apache.hadoop.ozone.container.TestContainerReplication ``` I feel this integration test is not needed. The logic we are testing here, is actually part of the placement policy and we can test for the original defect in TestSCMContainerPlacementRackAware much more efficiently and reliably. Here I have added a new test to TestSCMContainerPlacementRackAware and removed the test mentioned above. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-5690 ## How was this patch tested? New and existing tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
