ChenSammi commented on a change in pull request #2590:
URL: https://github.com/apache/ozone/pull/2590#discussion_r697392469
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NetworkTopologyImpl.java
##########
@@ -514,6 +514,13 @@ private Node chooseNodeInternal(String scope, int
leafIndex,
List<String> excludedScopes, Collection<Node> excludedNodes,
Node affinityNode, int ancestorGen) {
Preconditions.checkArgument(scope != null);
+ LOG.debug("Start choosing node[scope = {}, index = {}, excludedScopes =
{},"
Review comment:
@sodonnel , {} will not be evaluated until debug is enabled. You can
refer to this document,
http://www.slf4j.org/faq.html#logging_performance# What is the fastest way
of (not) logging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
