umamaheswararao commented on a change in pull request #2929:
URL: https://github.com/apache/ozone/pull/2929#discussion_r772593872
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECKeyOutputStream.java
##########
@@ -259,7 +259,7 @@ private StripeWriteStatus rewriteStripeToNewBlockGroup(int
chunkSize,
blockOutputStreamEntryPool.getCurrentStreamEntry();
newBlockGroupStreamEntry
.updateBlockGroupToAckedPosition(failedStripeDataSize);
- ecChunkBufferCache.clear(chunkSize);
Review comment:
writeParityCells allocating the buffers based on the current max chunk
size in that stripe. Lets say, the stripe smaller, then the chunksize for
parity could be smaller then default chunk size. So, we are allocating buffer
with that size. I think this will polute the bufferpool by creating differed
size buffers in it. Since we are using the pool globally now, we may need to
create same sized buffers and limit the sizes as needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
