umamaheswararao commented on pull request #2927:
URL: https://github.com/apache/ozone/pull/2927#issuecomment-999018201
We made it to server side defaults. So below two should be treated pretty
much same from client perspective.
```
If the client sends two replicationConfig fields, both optional:
Key ReplicationConfig
Client Default Replication Config
```
How about like: if client passes some config or client has default
replication config, then only we will send to server, otherwise it should be
simply null. So, Server will decide. If client passes any config, it will take
it, otherwise checks at bucket...if nothing at bucket then it should take
server default. However there are some challenges to solve at server as there
are assumptions and different flags to take default values when null from
client.
```
Ex: in OmKeyCreateRequest#preExecute:
boolean useRatis = ozoneManager.shouldUseRatis();
HddsProtos.ReplicationFactor factor = keyArgs.getFactor();
if (factor == null) {
factor = useRatis ? HddsProtos.ReplicationFactor.THREE :
HddsProtos.ReplicationFactor.ONE;
}
HddsProtos.ReplicationType type = keyArgs.getType();
if (type == null) {
type = useRatis ? HddsProtos.ReplicationType.RATIS :
HddsProtos.ReplicationType.STAND_ALONE;
}
```
I think this is a different problem exist. This JIRA can still go I think. I
have just filed a JIRA(HDDS-6131) to investigate address the above mentioned
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
