Attila Doroszlai created HDDS-6186:
--------------------------------------

             Summary: Selective checks: skip integration check for unit test 
changes
                 Key: HDDS-6186
                 URL: https://issues.apache.org/jira/browse/HDDS-6186
             Project: Apache Ozone
          Issue Type: Improvement
          Components: build, test
            Reporter: Attila Doroszlai
            Assignee: Attila Doroszlai


_unit_ and _integration_ checks run tests in mutually exclusive submodules. We 
may skip _integration_ check if only unit *tests* are changed.  However, we 
need to run _integration_ if any helper is changed, since we don't know if it's 
used by integration tests or not.

We can distinguish tests and test utilities by:

# file name pattern ({{Test\*.java}} are tests, others are utilities) OR
# extracting unit tests into separate submodule (similar to {{ratis-test}} in 
Ratis)

The first approach is quick and dirty.

The second one needs a bit more work, but is clean and has the additional 
benefit that all tests can be run despite any failures in dependencies.  
(Currently a test failure in e.g. {{hdds-common}} causes build/test in 
{{hdds-server-framework}} and other modules that depend on it.)  The downside 
is that it may cause many merge conflicts for everyone (feature branches, other 
in-progress work, open PRs).

I propose to do it now the first way, then do it properly after current feature 
branches are merged.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to