errose28 commented on a change in pull request #3052: URL: https://github.com/apache/ozone/pull/3052#discussion_r801925733
########## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java ########## @@ -254,6 +255,13 @@ public static void parseKVContainerData(KeyValueContainerData kvContainerData, if (!isBlockMetadataSet) { initializeUsedBytesAndBlockCount(store, kvContainerData); } + + // If the container is missing a chunks directory, possibly due to the + // bug fixed by HDDS-6235, create it here. + File chunksDir = new File(kvContainerData.getChunksPath()); + if (!chunksDir.exists()) { Review comment: parseKVContainerData is called on container import and startup. We are targeting the startup run to fix all the containers after the patch is applied. When this is called on import it should be a no-op since the chunks dir is now traveling with the tar as you mentioned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org