avijayanhwx commented on a change in pull request #3245:
URL: https://github.com/apache/ozone/pull/3245#discussion_r837765058
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -976,6 +976,14 @@
if the default value for this config is not used.
</description>
</property>
+ <property>
+ <name>hdds.recon.heartbeat.interval</name>
+ <value>30s</value>
Review comment:
DN Recon heartbeat interval can be 2x of DN-SCM interval == 60s.
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/StateContext.java
##########
@@ -149,6 +150,7 @@
*/
private final AtomicLong heartbeatFrequency = new AtomicLong(2000);
+ private final AtomicLong reconHeartbeatFrequency = new AtomicLong(2000);
Review comment:
nit. Why is the value of this AtomicLong different than the default
value of the heartbeat?
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/endpoint/RegisterEndpointTask.java
##########
@@ -176,7 +177,11 @@ public void setDatanodeDetails(
rpcEndPoint.getState().getNextState();
rpcEndPoint.setState(nextState);
rpcEndPoint.zeroMissedCount();
- this.stateContext.configureHeartbeatFrequency();
+ if (rpcEndPoint.getAddress().equals(getReconAddresses(conf))) {
Review comment:
Can we use rpcEndPoint.isPassive = true for Recon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
