ChenSammi commented on code in PR #3292:
URL: https://github.com/apache/ozone/pull/3292#discussion_r850401111
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/HddsVolumeUtil.java:
##########
@@ -215,6 +227,17 @@ public static boolean checkVolume(HddsVolume hddsVolume,
String scmId,
logger.error("Unable to create ID directory {} for datanode.", idDir);
return false;
}
+
+ if (VersionedDatanodeFeatures.SchemaV3.chooseSchemaVersion()
Review Comment:
Please use a helper function to detect whether SchemaV3 is enabled. And user
this helper function in all places where need a detection.
I discussed the feature with Arpit today. His suggestion is in the first
release version, we disable this feature by default. User can turn on it
manually. So other than this VersionedDataFeatures check, we may need a
property, which disable, or enable this feature, just like we did internally.
When this feature become mature enough, we deprecate this property and make
the feature always enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
