ChenSammi commented on code in PR #3615:
URL: https://github.com/apache/ozone/pull/3615#discussion_r935172684
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -783,6 +783,27 @@ public ScmInfo getScmInfo() throws IOException {
}
}
+ @Override
+ public int resetDeletedBlockRetryCount(List<Long> txIDs) throws IOException {
+ Map<String, String> auditMap = Maps.newHashMap();
+ getScm().checkAdminAccess(getRemoteUser());
+ try {
+ int count = scm.getScmBlockManager().getDeletedBlockLog().
+ resetCount(txIDs);
+ scm.getScmHAManager().asSCMHADBTransactionBuffer().flush();
Review Comment:
I think SCM will handle the flush itself. We don't need to control it.
Unless flush is a must to have here, I will recommend to remove it. Otherwise,
if user frequently call this API, SCM performance can be impacted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
