smengcl commented on code in PR #3653:
URL: https://github.com/apache/ozone/pull/3653#discussion_r955283855


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java:
##########
@@ -693,13 +693,12 @@ public OmMultipartUploadListParts listParts(String 
volumeName,
     boolean isTruncated = false;
     int nextPartNumberMarker = 0;
     BucketLayout bucketLayout = BucketLayout.DEFAULT;
-    if (ozoneManager != null) {

Review Comment:
   > If so, then it might be better just to remove the unused constructors here 
and deal with any merge conflicts when we do the merge to master. (It shouldn't 
be too bad.)
   
   Alright, let's do this on the snapshot branch then. We might have to deal 
with some conflicts if other PRs are changing `OzoneManager` around at the same 
time but yeah it shouldn't been too bad (most likely just `import` conflicts).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to