umamaheswararao commented on PR #3743: URL: https://github.com/apache/ozone/pull/3743#issuecomment-1246999294
>There may be a case like that in the future, but I think we should try to avoid it to keep things simple. In your example, with open replicas and under replication, we cannot use open containers for replication, so its better they are closed first. We could handle such a case by letting such a handler issue some commands and return false, or we could return some sort of status object in the chain to separate "handled" and "should continue", but for now we don't need it, so probably best to keep it simple and add later only if its needed. Exactly, I also thought to suggest the RESULT/RECOMMENDATION object instead of bool, where it can suggest what is the next step. So, chain handlers can make sure whether to return or need some additional handlers to be processed. But again I dropped that comment as we don't have any right now. We can think to refactor( that should not be big change) when it's really needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
