xBis7 commented on code in PR #3746:
URL: https://github.com/apache/ozone/pull/3746#discussion_r999367755
##########
hadoop-ozone/dist/src/main/smoketest/recon/recon-nssummary.robot:
##########
@@ -131,7 +132,8 @@ Check Recon Namespace Summary Key
Wait For Summary ${SUMMARY_URL}?path=/${VOLUME}/${BUCKET}/file1 KEY
Check Recon Namespace Summary Directory
- Wait For Summary ${SUMMARY_URL}?path=/${VOLUME}/${BUCKET}/dir1/dir2
DIRECTORY
+ Run Keyword If '${BUCKET_LAYOUT}' == 'LEGACY' Wait
For Summary ${SUMMARY_URL}?path=/${VOLUME}/${BUCKET}/dir1/dir2/ DIRECTORY
Review Comment:
The trailing slash is necessary. Without it, we get `PATH_NOT_FOUND` and
entity `UNKNOWN`.
> the command after this line 135 will only be executed when
'${BUCKET_LAYOUT}' == 'LEGACY'.
If bucket layout is FSO, it will run the command line below instead, with
the subtle difference of the trailing slash in the directory path.
You are right. That's how it works.
We give `${BUCKET_LAYOUT}` a default value of FSO and
[here](https://github.com/xBis7/ozone/blob/HDDS-7121/hadoop-ozone/dist/src/main/compose/ozone-legacy/test.sh#L31)
we execute the smoketest with value LEGACY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
