sodonnel commented on code in PR #3781:
URL: https://github.com/apache/ozone/pull/3781#discussion_r1004458588
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DatanodeAdminMonitorImpl.java:
##########
@@ -74,6 +76,58 @@ public class DatanodeAdminMonitorImpl implements
DatanodeAdminMonitor {
private Queue<DatanodeDetails> pendingNodes = new ArrayDeque();
private Queue<DatanodeDetails> cancelledNodes = new ArrayDeque();
private Set<DatanodeDetails> trackedNodes = new HashSet<>();
+ private NodeDecommissionMetrics metrics;
+ private long pipelinesWaitingToClose = 0;
+ private long sufficientlyReplicatedContainers = 0;
+ private long trackedDecomMaintenance = 0;
+ private long trackedRecommission = 0;
+ private long unhealthyContainers = 0;
+ private long underReplicatedContainers = 0;
+
+ private static final class ContainerStateInWorkflow {
+ private long sufficientlyReplicated = 0;
+ private long unhealthyContainers = 0;
+ private long underReplicatedContainers = 0;
+ private String host = "";
+ private long pipelinesWaitingToClose = 0;
+
+ private ContainerStateInWorkflow(String host,
+ long sufficientlyReplicated,
Review Comment:
Do we ever pass non-zeros for these values? Perhaps we can just drop these
parameters and let them default to zero?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
