errose28 commented on PR #3967: URL: https://github.com/apache/ozone/pull/3967#issuecomment-1317614844
Good catch on the pre-finalize case @sadanand48. I think the best thing to do here is introduce an s3 config for default bucket type to create from s3 gateway like you mentioned. The config will have no default value, and If this is not specified, then s3g will not send a bucket layout type causing the OM default type to be used. Here the OM can use LEGACY if it is pre-finalized. I am not sure there is a way to force s3g to use OBS buckets out of the box since it does not have the OM's pre-finalized state. At least by adding this new config, legacy buckets will not be created by default after #3966, and users can make s3g create OBS buckets if they want. #3966 will be making FSO the default bucket layout type on OM, and I will add handling there to use LEGACY buckets if OM is pre-finalized, regardless of the config value. For this reason I think this PR depends on that one, so we can pause here until that is finished. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
