dombizita commented on code in PR #3968:
URL: https://github.com/apache/ozone/pull/3968#discussion_r1024886377
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx:
##########
@@ -90,14 +90,12 @@ export class Overview extends
React.Component<Record<string, object>, IOverviewS
});
axios.all([
axios.get('/api/v1/clusterState'),
- axios.get('/api/v1/containers/missing'),
axios.get('/api/v1/task/status')
- ]).then(axios.spread((clusterStateResponse,
missingContainersResponse,taskstatusResponse) => {
+ ]).then(axios.spread((clusterStateResponse, taskstatusResponse) => {
const clusterState: IClusterStateResponse = clusterStateResponse.data;
- const missingContainers: IMissingContainersResponse =
missingContainersResponse.data;
const taskStatus = taskstatusResponse.data;
- const missingContainersCount = missingContainers.totalCount;
+ const missingContainersCount = clusterState.missingContainers;
Review Comment:
If the endpoint returns 1001 as the number of missing containers, that means
that actually we have more than 1000 missing containers and to avoid long
loading on the overview page we don't know the exact number. The tooltip should
show something like this (if 1001 containers are missing): "1000+ containers
are missing, for more information go to Containers page". If it is less than
1001, you can show the exact number instead of "1000+". What do you think?
@smitajoshi12 @devmadhuu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
