neils-dev commented on code in PR #4004:
URL: https://github.com/apache/ozone/pull/4004#discussion_r1034285076
##########
.github/workflows/post-commit.yml:
##########
@@ -17,414 +17,9 @@ on:
pull_request:
types: [opened, ready_for_review, synchronize]
push:
- schedule:
- - cron: 30 0,12 * * *
-env:
- FAIL_FAST: ${{ github.event_name == 'pull_request' }}
- MAVEN_OPTS: -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
-Dmaven.wagon.http.retryHandler.class=standard
-Dmaven.wagon.http.retryHandler.count=3
concurrency:
group: ci-${{ github.event.pull_request.number || github.sha }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}
jobs:
Review Comment:
Thanks @adoroszlai for simplifying the workflows and making the build-branch
workflow avail to new contributors with this patch.
With this change, we should also update the `Ozone CI with Githubs Actions
md `documentation file,
https://github.com/adoroszlai/hadoop-ozone/blob/09dfaffbd86a3adcd49402b61a251c98412c509e/.github/ci.md?plain=1#L1,
to note the the build-branch jobs are in the new `ci.yml` file that is
triggered on pull through the `post-commit.yml.` Perhaps also noting the
scheduling can be enabled / disabled on forks to run twice a day, (00:30 and
12:30) and updating that the scheduling is done through the new scheduled
`ci.yml`.
##########
.github/workflows/scheduled_ci.yml:
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+name: scheduled-ci
+on:
+ schedule:
+ - cron: 30 0,12 * * *
Review Comment:
> separate the scheduled workflow, so that it can be kept disabled in forks
The `schedule-ci `is active and triggered with the `schedule` event that
occurs every 12 hours, right? How are we going to disable it (the workflow)
for the new contributor forks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
