smengcl commented on code in PR #3985:
URL: https://github.com/apache/ozone/pull/3985#discussion_r1041505724
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1643,6 +1643,7 @@ message CreateSnapshotRequest {
required string volumeName = 1;
required string bucketName = 2;
Review Comment:
Unrelated to this PR, but we should mark these fields as `optional` before
we merge snapshot branch to master. Filed
https://issues.apache.org/jira/browse/HDDS-7600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
