hemantk-12 commented on code in PR #4015:
URL: https://github.com/apache/ozone/pull/4015#discussion_r1044862414
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -454,6 +454,8 @@ enum Status {
FEATURE_NOT_ENABLED = 86;
INVALID_SNAPSHOT_ERROR = 87;
+
+ BUCKET_SNAPSHOT_EXISTS = 88;
Review Comment:
Is it not supposed to be same as
[SNAPSHOT_EXISTS](https://github.com/apache/ozone/pull/4015/files#diff-3d3591532f36caba16c541dff5537ad381a3d6f562ae96b2d37ceaabfb531a84R264)?
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/exceptions/OMException.java:
##########
@@ -259,6 +259,8 @@ public enum ResultCodes {
FEATURE_NOT_ENABLED,
- INVALID_SNAPSHOT_ERROR
+ INVALID_SNAPSHOT_ERROR,
+
+ SNAPSHOT_EXISTS,
Review Comment:
Don't know if it is just me or `SNAPSHOT_EXISTS` sounds like "snapshot
already exists". Would it be better if we use `CONTAINS_SNAPSHOT`. Or something
along the line which tells customer that bucket or volume can't be deleted
because they contains snapshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
