devmadhuu commented on code in PR #4011:
URL: https://github.com/apache/ozone/pull/4011#discussion_r1045501609
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/PipelineSyncTask.java:
##########
@@ -64,17 +69,16 @@ public PipelineSyncTask(ReconPipelineManager
pipelineManager,
}
@Override
- protected synchronized void run() {
+ public void run() {
try {
while (canRun()) {
- long start = Time.monotonicNow();
- List<Pipeline> pipelinesFromScm = scmClient.getPipelines();
- reconPipelineManager.initializePipelines(pipelinesFromScm);
- syncOperationalStateOnDeadNodes();
- LOG.info("Pipeline sync Thread took {} milliseconds.",
- Time.monotonicNow() - start);
- recordSingleRunCompletion();
- wait(interval);
+ try {
+ lock.writeLock().lock();
Review Comment:
@sumitagrawl - changes fixed and pushed, pls re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
