xBis7 commented on PR #4054: URL: https://github.com/apache/ozone/pull/4054#issuecomment-1361314450
> The reason I chose it to be represented as a string earlier, is because we have done something similar for OM-HA https://github.com/apache/ozone/pull/3520 and SCM-HA https://github.com/apache/ozone/pull/2260, where we displayed the various roles of OM and SCM as strings, which was pretty simple for the user to understand and get information out of it. @ArafatKhan2198 I didn't know about that. I looked around and thought it's best to keep everything as key-value pairs to be more consistent and make it look like `PipelineInfo`. I don't know what the rest think about it. Based on all that, I'm fine with using a String. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
