dombizita commented on code in PR #4135:
URL: https://github.com/apache/ozone/pull/4135#discussion_r1060035831
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/PipelineEndpoint.java:
##########
@@ -77,7 +77,7 @@ public Response getPipelines() {
UUID pipelineId = pipeline.getId().getId();
List<String> datanodes = new ArrayList<>();
PipelineMetadata.Builder builder = PipelineMetadata.newBuilder();
- pipeline.getNodes().forEach(node -> datanodes.add(node.getHostName()));
+ pipeline.getNodes().forEach(node -> datanodes.add(node.getHostName() +
"/" + node.getUuid()));
Review Comment:
I agree with @myskov, it would be better to have list of `DatanodeDetails`
as `datanodes`, instead of string and attach the UUID with a slash.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/pipelines/pipelines.tsx:
##########
@@ -111,7 +111,15 @@ const COLUMNS = [
dataIndex: 'datanodes',
key: 'datanodes',
isSearchable: true,
- render: (datanodes: string[]) => <div>{datanodes.map(datanode => <div
key={datanode}>{datanode}</div>)}</div>
+ render: (datanodes: string[]) => <div> {datanodes.map(datanode =>
+ <div key={datanode}>
+ <div className='uuidtooltip'>
+ <Tooltip placement='top' title={`Uuid - ${datanode &&
datanode.split("/")[1]}`} getPopupContainer={(triggerNode) => triggerNode}>
Review Comment:
```suggestion
<Tooltip placement='top' title={`UUID: ${datanode &&
datanode.split("/")[1]}`} getPopupContainer={(triggerNode) => triggerNode}>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
