devmadhuu commented on code in PR #4042:
URL: https://github.com/apache/ozone/pull/4042#discussion_r1065349620
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/LegacyBucketHandler.java:
##########
@@ -322,4 +323,11 @@ public Table<String, OmKeyInfo> getKeyTable() {
getOmMetadataManager().getKeyTable(getBucketLayout());
return keyTable;
}
+
+ @Override
+ public OmDirectoryInfo getDirInfo(String[] names) throws IOException {
+ return OmDirectoryInfo.newBuilder()
+ .setName(names[2])
Review Comment:
>
@dombizita - getDirInfo method has caller only through
DirectoryEntityHandler and call stack for DirectoryEntityHandler will be
determined after validating the path , if path is directory, then only
DirectoryEntityHandler will be returned by EntityHandler.getEntityHandler , so
there is no way the current code flow will hit getDirInfo method if path is not
directory. First two indexes will be taken by Volume and Bucket in path and 3rd
index will be surely a directory. Please check the caller hierarchy of this
method. We can have zoom call to explain by sharing my screen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
