ChenSammi commented on code in PR #3874:
URL: https://github.com/apache/ozone/pull/3874#discussion_r1098646923
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/storage/DiskBalancerConfiguration.java:
##########
@@ -36,6 +38,17 @@ public final class DiskBalancerConfiguration {
private static final Logger LOG =
LoggerFactory.getLogger(DiskBalancerConfiguration.class);
+ // The path where datanode diskBalancer's conf is to be written to.
+ public static final String HDDS_DATANODE_DISK_BALANCER_INFO_DIR =
+ "hdds.datanode.disk.balancer.info.dir";
+
+ public static final String HDDS_DATANODE_DISK_BALANCER_VOLUME_CHOOSING_POLICY
+ = "hdds.datanode.disk.balancer.volume.choosing.policy";
+
+ public static final String
+ HDDS_DATANODE_DISK_BALANCER_CONTAINER_CHOOSING_POLICY =
+ "hdds.datanode.disk.balancer.container.choosing.policy";
+
Review Comment:
Do these three property have the default value? Can they use the @Config
format as other properties in this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
