fapifta commented on code in PR #4317:
URL: https://github.com/apache/ozone/pull/4317#discussion_r1122110527
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/DefaultCertificateClient.java:
##########
@@ -162,14 +154,6 @@ public abstract class DefaultCertificateClient implements
CertificateClient {
loadAllCertificates();
}
- public synchronized void setCertificateId(String certId) {
Review Comment:
Thank you @ChenSammi for the suggestion, after thinking it through, it is
really a better approach to kepp the method, so that the changes are more
safer. I re-added the method as a private method, and updated the code to use
that whenever the certSerialID is updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
