duongkame commented on PR #4345: URL: https://github.com/apache/ozone/pull/4345#issuecomment-1469395901
> Thanks @duongkame for working on this! I started running the new tests and after running them 30 times both `testSecretKeyAfterSCMFailover` and `testSecretKeyApiNotEnabled` failed at least once. Could they be flaky, or is this something that comes necessarily with MiniOzoneCluster tests? > > Overall the change looks good, I have left 2 suggestions for white space changes. Thanks, @Galsza for the review. I could actually reproduce the failure after running the tests continuously multiple times. Think I found the problem with a short waiting time in `testSecretKeySuccess` that causes flakiness. Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
