sodonnel commented on code in PR #4496:
URL: https://github.com/apache/ozone/pull/4496#discussion_r1152526165
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java:
##########
@@ -315,14 +315,8 @@ private int processMissingIndexes(
sourceDatanodesWithIndex, selectedDatanodes,
int2byte(missingIndexes),
repConfig);
- replicationManager.sendDatanodeCommand(reconstructionCommand,
- container, selectedDatanodes.get(0));
- // For each index that is going to be reconstructed with this command,
- // adjust the replica count to reflect the pending operation.
- for (int i = 0; i < missingIndexes.size(); i++) {
Review Comment:
This code was not adjusting the global pending ops. It was only adjusting
the local copy. I change I made only a week or two ago. I will restore it, as
it has caused a failing test which luckily caught the fact it should not be
removed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
