adoroszlai opened a new pull request, #4522:
URL: https://github.com/apache/ozone/pull/4522

   ## What changes were proposed in this pull request?
   
   Due to same root cause as HDDS-8276, `ozone debug read-replicas` may give 
wrong results with topology-aware read enabled.  It creates a single-node copy 
of the original pipeline for each replica, but only updates `nodes`, not 
`nodesInOrder`.  If the replica is stale (offline but not yet dead), read is 
attempted and fails, and the client checks if there are any fallback nodes.  
There should be none left (single-node pipeline), but with topology-aware read 
enabled the other two nodes are still present in the list.
   
   This PR moves the fix that was originally added for EC file checksum to the 
pipeline copy builder, so that all usages get fixed (currently only these two 
cases change nodes in the copy pipeline).
   
   https://issues.apache.org/jira/browse/HDDS-8364
   
   ## How was this patch tested?
   
   Updated relevant smoketest to enable topology-aware read for this command, 
ran locally.
   
   Ran `TestOzoneFileChecksum` for regression.
   
   CI:
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/4598039439


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to