adoroszlai commented on code in PR #4517: URL: https://github.com/apache/ozone/pull/4517#discussion_r1156806181
########## hadoop-hdds/hadoop-dependency-test/pom.xml: ########## @@ -54,6 +54,10 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> </exclusion> </exclusions> </dependency> + <dependency> + <groupId>commons-codec</groupId> + <artifactId>commons-codec</artifactId> + </dependency> Review Comment: `OzoneBlockTokenIdentifier` is in `hadoop-hdds/common`, so I'm moving the test to the same submodule. This dependency is required at runtime for Hadoop code invoked by the test. ``` [ERROR] Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.506 s <<< FAILURE! - in org.apache.hadoop.hdds.security.token.TestOzoneBlockTokenIdentifier [ERROR] org.apache.hadoop.hdds.security.token.TestOzoneBlockTokenIdentifier.testTokenSerialization Time elapsed: 0.04 s <<< ERROR! java.lang.NoClassDefFoundError: org/apache/commons/codec/binary/Base64 at org.apache.hadoop.security.token.Token.encodeWritable(Token.java:342) at org.apache.hadoop.security.token.Token.encodeToUrlString(Token.java:373) at org.apache.hadoop.hdds.security.token.TestOzoneBlockTokenIdentifier.testTokenSerialization(TestOzoneBlockTokenIdentifier.java:169) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
