neils-dev commented on code in PR #4493:
URL: https://github.com/apache/ozone/pull/4493#discussion_r1162304194
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMSecurityProtocolServer.java:
##########
@@ -225,9 +214,9 @@ public String getSCMCertificate(ScmNodeDetailsProto
scmNodeDetails,
private String getEncodedCertToString(String certSignReq, NodeType nodeType)
throws IOException {
Future<CertPath> future;
- if (nodeType == NodeType.SCM) {
+ if (nodeType == NodeType.SCM && rootCertificateServer != null) {
Review Comment:
Thanks @ChenSammi for clarifying. Makes sense - remove rootCA signing
limitation and sign with rootCA if present on SCM otherwise sign with sub-CA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
